[GitHub] [superset] rusackas commented on a change in pull request #18749: fix(sqllab): Removed the tooltip from CopyToClipboard button in sqllab

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #18749:
URL: https://github.com/apache/superset/pull/18749#discussion_r808408570



##########
File path: superset-frontend/src/components/CopyToClipboard/index.jsx
##########
@@ -88,15 +88,7 @@ class CopyToClipboard extends React.Component {
 
   renderNotWrapped() {
     return (
-      <Tooltip
-        id="copy-to-clipboard-tooltip"
-        placement="top"
-        style={{ cursor: 'pointer' }}
-        title={this.props.tooltipText}
-        trigger={['hover']}
-      >
-        {this.getDecoratedCopyNode()}
-      </Tooltip>
+      this.getDecoratedCopyNode()

Review comment:
       Agreed, the solution should be prop-based. Either
   * render the tooltip conditionally (if it was passed a meaningful title)
   * provide a prop or other means (e.g. title={false}) to intentionally hide the tooltip
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org