[GitHub] [solr] cpoerschke commented on a change in pull request #9: SOLR-15225: maintain existing test naming conventions (contrib/analytics, contrib/ltr)

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #9:
URL: https://github.com/apache/solr/pull/9#discussion_r592206443



##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -19,10 +19,12 @@
 
 import java.lang.invoke.MethodHandles;
 import java.io.File;
+import java.util.regex.Pattern;
 
 import com.carrotsearch.randomizedtesting.annotations.ThreadLeakLingering;
 import org.apache.lucene.util.LuceneTestCase;
 import org.apache.lucene.util.QuickPatchThreadsFilter;
+import org.apache.lucene.util.VerifyTestClassNamingConvention;

Review comment:
       Hmm, how mysterious, https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/util/QuickPatchThreadsFilter.java and https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/util/VerifyTestClassNamingConvention.java are both "neighbours" but somehow there's difficulty discovering `VerifyTestClassNamingConvention` somehow? Had seen this locally but assumed it must be my setup somehow, hmm.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org