You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/06 16:14:00 UTC
[jira] [Work logged] (BEAM-11272) Combiner Label Constructor Arg
Not Passed Through To pTransform
[ https://issues.apache.org/jira/browse/BEAM-11272?focusedWorklogId=531946&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531946 ]
ASF GitHub Bot logged work on BEAM-11272:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/21 16:13
Start Date: 06/Jan/21 16:13
Worklog Time Spent: 10m
Work Description: rgruener commented on pull request #13355:
URL: https://github.com/apache/beam/pull/13355#issuecomment-755395143
> I think you can safely remove these constructors.
@kamilwu That makes sense, I have removed the constructors. Should I update the JIRA ticket to reflect this? Also labels can still be passed into the generic ptransform constructor. Should that be removed as well? https://github.com/apache/beam/blob/b2ad4ddbf16fe6680a4876dfa3f093d1db5be8ec/sdks/python/apache_beam/transforms/ptransform.py#L348-L351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 531946)
Time Spent: 1h 40m (was: 1.5h)
> Combiner Label Constructor Arg Not Passed Through To pTransform
> ---------------------------------------------------------------
>
> Key: BEAM-11272
> URL: https://issues.apache.org/jira/browse/BEAM-11272
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robbie Gruener
> Priority: P3
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The combiners ToSet, ToDict, and ToList have a label argument in their constructor:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/combiners.py#L877]
>
> However the label passed through to the parent class is not actually used (there is a mismatch in the super constructor) https://github.com/apache/beam/blob/7ac82a875462f2c2570a1157b782ebadddebbe70/sdks/python/apache_beam/transforms/combiners.py#L68
--
This message was sent by Atlassian Jira
(v8.3.4#803005)