You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/09/30 15:58:24 UTC
[kudu-CR] Bump up min negotiation threads in disk reservation-itest
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4575
Change subject: Bump up min negotiation threads in disk_reservation-itest
......................................................................
Bump up min negotiation threads in disk_reservation-itest
TSAN flakiness seems to be caused by slow thread creation in the
negotiation pool, so we simply pre-spawn those threads in this test.
This change took high-stress TSAN runs using dist-test from ~6% flaky to
0% flaky.
Change-Id: I34c35f0260d5688661972226ff207dc07bd5ecf6
---
M src/kudu/integration-tests/disk_reservation-itest.cc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/4575/1
--
To view, visit http://gerrit.cloudera.org:8080/4575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34c35f0260d5688661972226ff207dc07bd5ecf6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] Bump up min negotiation threads in disk reservation-itest
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Bump up min negotiation threads in disk_reservation-itest
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4575/1//COMMIT_MSG
Commit Message:
PS1, Line 10: pre-spawn those threads in this test.
Why only this test? TSAN causes thread startup to be slow across the board, so why not prespawn #if THREAD_SANITIZER universally? Either in the Messenger implementation, or by adding the appropriate flags to all mini cluster users.
I still have a preference for bumping FLAGS_rpc_negotiation_timeout_ms, but this is orthogonal.
--
To view, visit http://gerrit.cloudera.org:8080/4575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34c35f0260d5688661972226ff207dc07bd5ecf6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Bump up min negotiation threads in disk reservation-itest
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Bump up min negotiation threads in disk_reservation-itest
......................................................................
Patch Set 1:
Fixing KUDU-1580 would also probably be a good way to address the root cause instead of a workaround (and tackle flakiness across many tests, plus a real issue)
--
To view, visit http://gerrit.cloudera.org:8080/4575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34c35f0260d5688661972226ff207dc07bd5ecf6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Bump up min negotiation threads in disk reservation-itest
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Bump up min negotiation threads in disk_reservation-itest
......................................................................
Patch Set 1:
I think http://gerrit.cloudera.org:8080/4593 may be a better approach here. I'm guessing that, for some reason, disk_reservation-itest was triggering a lot of suppressed races, which caused the threads to take a long time to start.
--
To view, visit http://gerrit.cloudera.org:8080/4575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34c35f0260d5688661972226ff207dc07bd5ecf6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Bump up min negotiation threads in disk reservation-itest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: Bump up min negotiation threads in disk_reservation-itest
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I34c35f0260d5688661972226ff207dc07bd5ecf6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>