You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/04 14:28:05 UTC
[GitHub] [rocketmq] horizonzy opened a new pull request #2550: [ISSUE #2549] Remove useless method invoke about MessageDecoder.decodeMessageId
horizonzy opened a new pull request #2550:
URL: https://github.com/apache/rocketmq/pull/2550
## What is the purpose of the change
For-#2549
Remove useless method invoke about MessageDecoder.decodeMessageId
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #2550: [ISSUE #2549] Remove useless method invoke about MessageDecoder.decodeMessageId
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2550:
URL: https://github.com/apache/rocketmq/pull/2550#issuecomment-754384212
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2550?src=pr&el=h1) Report
> Merging [#2550](https://codecov.io/gh/apache/rocketmq/pull/2550?src=pr&el=desc) (98aca7f) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0239421fa59b67c423cf9fcabf5cd6edda0c2076?el=desc) (0239421) will **increase** coverage by `0.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/2550?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2550 +/- ##
=============================================
+ Coverage 45.97% 46.28% +0.31%
- Complexity 4318 4349 +31
=============================================
Files 547 547
Lines 36236 36247 +11
Branches 4808 4808
=============================================
+ Hits 16658 16777 +119
+ Misses 17491 17391 -100
+ Partials 2087 2079 -8
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2550?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/rocketmq/remoting/netty/ResponseFuture.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Jlc3BvbnNlRnV0dXJlLmphdmE=) | `85.00% <0.00%> (-5.00%)` | `16.00% <0.00%> (-2.00%)` | |
| [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `46.86% <0.00%> (-4.06%)` | `20.00% <0.00%> (-2.00%)` | |
| [...mq/client/consumer/store/LocalFileOffsetStore.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvTG9jYWxGaWxlT2Zmc2V0U3RvcmUuamF2YQ==) | `56.86% <0.00%> (-1.97%)` | `19.00% <0.00%> (ø%)` | |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `56.55% <0.00%> (-0.03%)` | `109.00% <0.00%> (ø%)` | |
| [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (ø)` | `30.00% <0.00%> (ø%)` | |
| [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `12.31% <0.00%> (+0.21%)` | `25.00% <0.00%> (+1.00%)` | |
| [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `47.24% <0.00%> (+0.32%)` | `26.00% <0.00%> (ø%)` | |
| [...ava/org/apache/rocketmq/store/ha/HAConnection.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0hBQ29ubmVjdGlvbi5qYXZh) | `75.00% <0.00%> (+0.46%)` | `5.00% <0.00%> (ø%)` | |
| [...n/java/org/apache/rocketmq/store/ha/HAService.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0hBU2VydmljZS5qYXZh) | `68.54% <0.00%> (+0.66%)` | `18.00% <0.00%> (ø%)` | |
| [.../rocketmq/client/impl/consumer/PullAPIWrapper.java](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsQVBJV3JhcHBlci5qYXZh) | `51.28% <0.00%> (+0.85%)` | `13.00% <0.00%> (+1.00%)` | |
| ... and [22 more](https://codecov.io/gh/apache/rocketmq/pull/2550/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2550?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2550?src=pr&el=footer). Last update [0239421...0284b3d](https://codecov.io/gh/apache/rocketmq/pull/2550?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 closed pull request #2550: [ISSUE #2549] Remove useless method invoke about MessageDecoder.decodeMessageId
Posted by GitBox <gi...@apache.org>.
yuz10 closed pull request #2550:
URL: https://github.com/apache/rocketmq/pull/2550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2550: [ISSUE #2549] Remove useless method invoke about MessageDecoder.decodeMessageId
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2550:
URL: https://github.com/apache/rocketmq/pull/2550#issuecomment-754014097
[](https://coveralls.io/builds/36065302)
Coverage decreased (-0.02%) to 51.917% when pulling **0284b3d8535f2bb2f43c544e1e5af186e9593f7f on horizonzy:remove-useless-method-invoke** into **98aca7ffcbf282b2885ad4b9c433927a5ac0e78b on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org