You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/23 18:01:18 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8746: ARROW-10688: [Rust] [DataFusion] Implement CASE WHEN logical plan

jorgecarleitao commented on a change in pull request #8746:
URL: https://github.com/apache/arrow/pull/8746#discussion_r528896150



##########
File path: rust/datafusion/src/optimizer/filter_push_down.rs
##########
@@ -93,7 +93,9 @@ fn issue_filters(
     let predicate = predicates
         .iter()
         .skip(1)
-        .fold(predicates[0].clone(), |acc, predicate| and(&acc, predicate));
+        .fold(predicates[0].clone(), |acc, predicate| {
+            and(acc, (*predicate).clone())

Review comment:
       do you think it is worth adding a test to this? Looks non-trivial :/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org