You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/09/01 11:10:00 UTC
[jira] [Commented] (LUCENE-8778) Define analyzer SPI names as
static final fields and document the names in Javadocs
[ https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920374#comment-16920374 ]
ASF subversion and git services commented on LUCENE-8778:
---------------------------------------------------------
Commit 8c124337914643a89c278fa7f9c56a78f2a6270e in lucene-solr's branch refs/heads/master from Tomoko Uchida
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8c12433 ]
LUCENE-8778: Fix (uncapitalize) SPI names.
> Define analyzer SPI names as static final fields and document the names in Javadocs
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-8778
> URL: https://issues.apache.org/jira/browse/LUCENE-8778
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/analysis
> Reporter: Tomoko Uchida
> Assignee: Tomoko Uchida
> Priority: Minor
> Fix For: master (9.0)
>
> Attachments: LUCENE-8778-koreanNumber.patch, LUCENE-8778-migrate-note.patch, ListAnalysisComponents.java, SPINamesGenerator.java, Screenshot from 2019-04-26 02-17-48.png, Screenshot from 2019-05-25 23-25-24.png, TestSPINames.java
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Each built-in analysis component (factory of tokenizer / char filter / token filter) has a SPI name but currently this is not documented anywhere.
> The goals of this issue:
> * Define SPI names as static final field for each analysis component so that users can get the component by name (via {{NAME}} static field.) This also provides compile time safety.
> * Officially document the SPI names in Javadocs.
> * Add proper source validation rules to ant {{validate-source-patterns}} target so that we can make sure that all analysis components have correct field definitions and documentation
> and,
> * Lookup SPI names on the new {{NAME}} fields. Instead deriving those from class names.
> (Just for quick reference) we now have:
> * *19* Tokenizers ({{TokenizerFactory.availableTokenizers()}})
> * *6* CharFilters ({{CharFilterFactory.availableCharFilters()}})
> * *118* TokenFilters ({{TokenFilterFactory.availableTokenFilters()}})
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org