You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/10/08 23:32:58 UTC

[GitHub] [hive] saihemanth-cloudera commented on a change in pull request #2634: HIVE-25514: Alter table with partitions should honor {OWNER} policies

saihemanth-cloudera commented on a change in pull request #2634:
URL: https://github.com/apache/hive/pull/2634#discussion_r725391998



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -5461,6 +5462,37 @@ public GetPartitionResponse get_partition_req(GetPartitionRequest req)
    */
   private void fireReadTablePreEvent(String catName, String dbName, String tblName)
       throws MetaException, NoSuchObjectException {
+    if (catName == null) {
+      throw new NullPointerException("catName is null");
+    }
+
+    if (isBlank(catName)) {

Review comment:
       Yeah. I tried doing it but few tests in TestGetPartitions is failing because it is expecting to fail with NullPointerException.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org