You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/26 17:15:34 UTC

[GitHub] [beam] TheNeuralBit edited a comment on pull request #14101: [BEAM-11436] Never run checkerframework on tests

TheNeuralBit edited a comment on pull request #14101:
URL: https://github.com/apache/beam/pull/14101#issuecomment-786777942


   Ok, turns out the conflicts weren't trivial, because additional suppression were added in the meantime. I found the following worked:
   ```
   # Remove any lines with just nullness TODO(BEAM-10402)
   sed -Ei '/^\s*"nullness"\s*\/\/\s*TODO\(https:\/\/issues.apache.org\/jira\/browse\/BEAM-10402\)\s*$/d' **/test/**/*.java
   # Run spotless, then remove empty SuppressWarnings annotations
   ./gradlew spotlessApply
   sed -Ei '/@SuppressWarnings\(\{\}\)/d' **/test/**/*.java
   ```
   
   Then I ran `grep -IirnEl 'BEAM-10402' **/test/**/*.java` to identify the last ~10 that needed to be cleaned up manually.
   
   This is committed in ebe1105


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org