You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2017/12/08 15:53:41 UTC
Review Request 64451: SENTRY-2094: Enable TestHDFSIntegrationWithHA
tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64451/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na Li.
Bugs: sentry-2094
https://issues.apache.org/jira/browse/sentry-2094
Repository: sentry
Description
-------
Enable HA for HDFS integration tests
Diffs
-----
sentry-tests/sentry-tests-hive-v2/pom.xml 680481c5b8f9e782c53d704a9b4c1fb61dd15be8
sentry-tests/sentry-tests-hive/pom.xml 11b7917a83691ba6e9df7472aa4b99c16e07b1c8
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
Diff: https://reviews.apache.org/r/64451/diff/1/
Testing
-------
All tests passed.
Thanks,
Sergio Pena
Re: Review Request 64451: SENTRY-2094: Enable
TestHDFSIntegrationWithHA tests
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64451/#review193269
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Dec. 8, 2017, 3:53 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64451/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 3:53 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: sentry-2094
> https://issues.apache.org/jira/browse/sentry-2094
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Enable HA for HDFS integration tests
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive-v2/pom.xml 680481c5b8f9e782c53d704a9b4c1fb61dd15be8
> sentry-tests/sentry-tests-hive/pom.xml 11b7917a83691ba6e9df7472aa4b99c16e07b1c8
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
>
>
> Diff: https://reviews.apache.org/r/64451/diff/1/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 64451: SENTRY-2094: Enable
TestHDFSIntegrationWithHA tests
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
> On Dec. 8, 2017, 8:14 p.m., Na Li wrote:
> > You can remove some comment no longer valid such as "//TODO: SENTRY-795: HDFS permissions do not sync when Sentry restarts in HA mode."
True. I'll do that.
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64451/#review193276
-----------------------------------------------------------
On Dec. 8, 2017, 3:53 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64451/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 3:53 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: sentry-2094
> https://issues.apache.org/jira/browse/sentry-2094
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Enable HA for HDFS integration tests
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive-v2/pom.xml 680481c5b8f9e782c53d704a9b4c1fb61dd15be8
> sentry-tests/sentry-tests-hive/pom.xml 11b7917a83691ba6e9df7472aa4b99c16e07b1c8
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
>
>
> Diff: https://reviews.apache.org/r/64451/diff/1/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 64451: SENTRY-2094: Enable
TestHDFSIntegrationWithHA tests
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64451/#review193276
-----------------------------------------------------------
You can remove some comment no longer valid such as "//TODO: SENTRY-795: HDFS permissions do not sync when Sentry restarts in HA mode."
- Na Li
On Dec. 8, 2017, 3:53 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64451/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 3:53 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na Li.
>
>
> Bugs: sentry-2094
> https://issues.apache.org/jira/browse/sentry-2094
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Enable HA for HDFS integration tests
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive-v2/pom.xml 680481c5b8f9e782c53d704a9b4c1fb61dd15be8
> sentry-tests/sentry-tests-hive/pom.xml 11b7917a83691ba6e9df7472aa4b99c16e07b1c8
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
>
>
> Diff: https://reviews.apache.org/r/64451/diff/1/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Sergio Pena
>
>