[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #625: Allow migration of detached volumes

[GitBox <gi...@apache.org>]

davidjumani commented on a change in pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625#discussion_r478967267



##########
File path: src/config/section/storage.js
##########
@@ -168,7 +168,7 @@ export default {
           label: 'label.migrate.volume',
           args: ['volumeid', 'storageid', 'livemigrate'],
           dataView: true,
-          show: (record, store) => { return record.state === 'Ready' && ['Admin'].includes(store.userInfo.roletype) && record.virtualmachineid },
+          show: (record, store) => { return record.state === 'Ready' && ['Admin'].includes(store.userInfo.roletype) },

Review comment:
       @rhtyd 
   ```
   if (jsonObj.type == "ROOT" || jsonObj.type == "DATADISK") {
     if (jsonObj.state == "Ready" && isAdmin() && jsonObj.virtualmachineid != null) {
       allowedActions.push("migrateVolume");
     }
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org