[jira] [Commented] (GROOVY-7967) AstNodeToScriptAdapter should output source using the recommended modifier order

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565148#comment-15565148 ] 

ASF GitHub Bot commented on GROOVY-7967:
----------------------------------------

GitHub user paulk-asert opened a pull request:

    https://github.com/apache/groovy/pull/447

    GROOVY-7967: AstNodeToScriptAdapter should output source using the re…

    …commended modifier order

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/groovy groovy7967

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/447.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #447
    
----
commit 56ef98545aa48236d053bdf8190922c5c787e1e3
Author: paulk <pa...@asert.com.au>
Date:   2016-10-11T10:50:48Z

    GROOVY-7967: AstNodeToScriptAdapter should output source using the recommended modifier order

----


> AstNodeToScriptAdapter should output source using the recommended modifier order
> --------------------------------------------------------------------------------
>
>                 Key: GROOVY-7967
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7967
>             Project: Groovy
>          Issue Type: Bug
>            Reporter: Paul King
>            Assignee: Paul King
>              Labels: breaking
>
> This source file:
> {code}
> interface Foo { }
> {code}
> when 'reprinted' via the groovyConsole shows up as:
> {code}
> abstract interface public class Foo extends java.lang.Object {  }
> {code}
> We don't need to have both 'interface' and 'class' and the modifier order should follow the JLS recommendations.
> In some sense this is a trviial change but we do have numerous tests which output the resulting source and check the value. We'll need to refactor those.
> It is a breaking change only if the old source order was being relied upon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)