You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ni...@apache.org on 2022/05/17 04:33:04 UTC
[incubator-seatunnel] branch dev updated: [Bug] [test] Auto close FileSource (#1634)
This is an automated email from the ASF dual-hosted git repository.
nielifeng pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new f7ecacb9 [Bug] [test] Auto close FileSource (#1634)
f7ecacb9 is described below
commit f7ecacb98a33491b15238c691305f73840ce8e28
Author: Benedict Jin <as...@apache.org>
AuthorDate: Tue May 17 12:32:59 2022 +0800
[Bug] [test] Auto close FileSource (#1634)
---
.../seatunnel/fink/file/source/FileSourceTest.java | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-file/src/test/java/org/apache/seatunnel/fink/file/source/FileSourceTest.java b/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-file/src/test/java/org/apache/seatunnel/fink/file/source/FileSourceTest.java
index 1769c84e..7a582965 100644
--- a/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-file/src/test/java/org/apache/seatunnel/fink/file/source/FileSourceTest.java
+++ b/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-file/src/test/java/org/apache/seatunnel/fink/file/source/FileSourceTest.java
@@ -41,23 +41,25 @@ public class FileSourceTest {
// *****************************************************************************
@Test
- public void getJsonDate() {
+ public void getJsonDate() throws Exception {
String configFile = "flink.streaming.json.conf";
FlinkEnvironment flinkEnvironment = createFlinkStreamEnvironment(configFile);
- FileSource fileSource = createFileSource(configFile, flinkEnvironment);
- DataSet<Row> data = fileSource.getData(flinkEnvironment);
- Assert.assertNotNull(data);
+ try (FileSource fileSource = createFileSource(configFile, flinkEnvironment)) {
+ DataSet<Row> data = fileSource.getData(flinkEnvironment);
+ Assert.assertNotNull(data);
+ }
}
@Test
- public void getTextData() {
+ public void getTextData() throws Exception {
String configFile = "flink.streaming.text.conf";
FlinkEnvironment flinkEnvironment = createFlinkStreamEnvironment(configFile);
- FileSource fileSource = createFileSource(configFile, flinkEnvironment);
- DataSet<Row> data = fileSource.getData(flinkEnvironment);
- Assert.assertNotNull(data);
+ try (FileSource fileSource = createFileSource(configFile, flinkEnvironment)) {
+ DataSet<Row> data = fileSource.getData(flinkEnvironment);
+ Assert.assertNotNull(data);
+ }
}
private FlinkEnvironment createFlinkStreamEnvironment(String configFile) {