You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "KarboniteKream (via GitHub)" <gi...@apache.org> on 2026/09/21 05:07:58 UTC
[PR] Use the correct buffer in `read()` methods [thrift]
KarboniteKream opened a new pull request, #3920:
URL: https://github.com/apache/thrift/pull/3920
Client: js,nodejs
This PR fixes a typo in the `read()` methods, which were reading from `read_buf` instead of `recv_buf`.
Co-Authored-By: OpenAI Codex (GPT-6) <co...@openai.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the correct buffer in `read()` methods [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3920:
URL: https://github.com/apache/thrift/pull/3920#issuecomment-5761516899
### Code review
No blocking issues found. Checked for bugs and CLAUDE.md compliance.
One suggestion, below the bar for an issue but verified:
- A small formality for when you next push: the commit message is only the subject line. CONTRIBUTING.md asks for a `Client: js,nodejs` line below the subject, and AGENTS.md asks for the AI label on the commit as well as on the PR, so the `Co-Authored-By: OpenAI Codex <co...@openai.com>` line from the PR description belongs in the commit message too.
https://github.com/apache/thrift/blob/c2653b305be9087722daef73f29628b7e382f157/CONTRIBUTING.md#L22-L27
https://github.com/apache/thrift/blob/c2653b305be9087722daef73f29628b7e382f157/AGENTS.md#L60-L65
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the correct buffer in `read()` methods [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G closed pull request #3920: Use the correct buffer in `read()` methods
URL: https://github.com/apache/thrift/pull/3920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the correct buffer in `read()` methods [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3920:
URL: https://github.com/apache/thrift/pull/3920#issuecomment-5765497375
Thank you! This change is on master as aeae8b2c5, with you as the author. It went in through #3923 (THRIFT-6331), which was stacked on it, so I'm closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org