[GitHub] [arrow] dragosmg commented on a diff in pull request #13070: ARROW-15804: [R] Update as.Date() to support several tryFormats

[GitBox <gi...@apache.org>]

dragosmg commented on code in PR #13070:
URL: https://github.com/apache/arrow/pull/13070#discussion_r869364766


##########
r/tests/testthat/test-dataset-dplyr.R:
##########
@@ -80,26 +80,29 @@ test_that("filter() on timestamp columns", {
     df1[5:10, c("ts")],
   )
 
-  # Now with Date
+  # Now with bare string date
+  skip("Implement more aggressive implicit casting for scalars (ARROW-11402)")
   expect_equal(
     ds %>%
-      filter(ts >= as.Date("2015-05-04")) %>%
+      filter(ts >= "2015-05-04") %>%
       filter(part == 1) %>%
       select(ts) %>%
       collect(),
     df1[5:10, c("ts")],
   )
 
-  # Now with bare string date
-  skip("Implement more aggressive implicit casting for scalars (ARROW-11402)")
+  # string processing requires RE2 library (not available on Windows with R 3.6)
+  skip_if_not_available("re2")

Review Comment:
   I moved this test at the end of the test block since the `as.Date()` binding now depends on RE2 (not available in R 3.6 on Windows).



##########
r/tests/testthat/test-dataset-dplyr.R:
##########
@@ -108,18 +111,20 @@ test_that("filter() on date32 columns", {
   df <- data.frame(date = as.Date(c("2020-02-02", "2020-02-03")))
   write_parquet(df, file.path(tmp, "file.parquet"))
 
+  # Also with timestamp scalar
   expect_equal(
     open_dataset(tmp) %>%
-      filter(date > as.Date("2020-02-02")) %>%
+      filter(date > lubridate::ymd_hms("2020-02-02 00:00:00")) %>%
       collect() %>%
       nrow(),
     1L
   )
 
-  # Also with timestamp scalar
+  # string processing requires RE2 library (not available on Windows with R 3.6)
+  skip_if_not_available("re2")

Review Comment:
   Same as above - `as.Date()` now needs RE2.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org