[GitHub] [incubator-pinot] mqliang commented on pull request #6820: Add ago() scalar transform function

[GitBox <gi...@apache.org>]

mqliang commented on pull request #6820:
URL: https://github.com/apache/incubator-pinot/pull/6820#issuecomment-823594856


   @Jackie-Jiang 
   > Is ago() a standard sql function? I feel it might be more intuitive to use now() +/- period('PT1H)?
   
   I think adding a `period_add(now(), 'PT1H')` function looks much better:
   *  It can accept a positive/negative period to get a time before/after a given period.  
   *  The first parameter can not only be `now()`, but also be some other time  expression, so much more flexible.
   *  MySQL has such a function: https://w3resource.com/mysql/date-and-time-functions/mysql-period_add-function.php. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org