[GitHub] [flink] hackeryard commented on a diff in pull request #20016: [FLINK-27857][hive] HiveSource supports filter push down for orc format

[GitBox <gi...@apache.org>]

hackeryard commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036585698


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields, DataType producedDataType)
         this.projectedFields = Arrays.stream(projectedFields).mapToInt(value -> value[0]).toArray();
     }
 
+    @Override
+    public Result applyFilters(List<ResolvedExpression> filters) {
+        this.filters = new ArrayList<>(filters);
+        return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));

Review Comment:
   Is this unimplemented to support orc filter pushdown?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org