[GitHub] [samza] byjiang1996 commented on a change in pull request #1405: SAMZA-2570: Add app.env into configs

[GitBox <gi...@apache.org>]

byjiang1996 commented on a change in pull request #1405:
URL: https://github.com/apache/samza/pull/1405#discussion_r461962614



##########
File path: samza-core/src/main/java/org/apache/samza/util/Util.java
##########
@@ -51,6 +51,10 @@ public static String envVarEscape(String str) {
         .replace("`", "\\`");
   }
 
+  public static String getAppEnv(Config config) {
+    return new ApplicationConfig(config).getAppEnv();
+  }
+

Review comment:
       That's a good question... 
   If you look at this Util.java's getTaskClassVersion() function, you will find it still calls ApplicationConfig's getAppClass function. 
   Not sure whether I need to add a getAppEnv() method in Util.java. What's your opinion?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org