You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by omalley <gi...@git.apache.org> on 2018/03/26 16:45:24 UTC

[GitHub] orc issue #227: ORC-318. Change KeyProvider API to separate createLocalKey

Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/227
  
    Ok, I significantly updated this patch.
    * I added tests for both the InMemoryKeyProvider and the Hadoop-based KeyProvider.
    * I allowed the user to pass in a Random implementation for the KeyProvider. That allows me to control the random for tests.
    * I added a lot of documentation about what I was doing and why.
    * I fixed an issue where the HadoopShimsFactory wasn't creating the right version of the shim.
    * I changed the InMemoryKeyProvider to use AES/CBC/NoPadding to encrypt and decrypt the local keys. Thus like the AWS KMS, the operations for encryption and decryption aren't symmetric.


---