You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2016/08/30 07:30:25 UTC
[02/12] git commit: [flex-falcon] [refs/heads/develop] - [BUGFIX]
[REVIEW REQUESTED] Fix for inconsistent (and erroneous) implementation of
classes marked as Bindable. This needs review. This was causing some
implementations to extend EventDispatcher. It
[BUGFIX] [REVIEW REQUESTED] Fix for inconsistent (and erroneous) implementation of classes marked as Bindable.
This needs review. This was causing some implementations to extend EventDispatcher.
It was also incorrectly applying the implementation to classes with only static bindables.
The assumption is that ClassDirectiveProcessor handles the bindable implementation as a single authoritative source.
The inconsistent implementation here was commented out, other code that appears unrelated to Binding support was left as is.
Please review whether the above assumption is correct and/or whether this should be re-implemented with consistency.
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/10486cc7
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/10486cc7
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/10486cc7
Branch: refs/heads/develop
Commit: 10486cc7194fa222d51b5a1221c621b6e06f8463
Parents: cf9d0f2
Author: greg-dove <gr...@gmail.com>
Authored: Tue Aug 23 13:24:44 2016 +1200
Committer: greg-dove <gr...@gmail.com>
Committed: Tue Aug 23 13:24:44 2016 +1200
----------------------------------------------------------------------
.../compiler/internal/units/ASCompilationUnit.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/10486cc7/compiler/src/main/java/org/apache/flex/compiler/internal/units/ASCompilationUnit.java
----------------------------------------------------------------------
diff --git a/compiler/src/main/java/org/apache/flex/compiler/internal/units/ASCompilationUnit.java b/compiler/src/main/java/org/apache/flex/compiler/internal/units/ASCompilationUnit.java
index ab60b1f..a857cda 100644
--- a/compiler/src/main/java/org/apache/flex/compiler/internal/units/ASCompilationUnit.java
+++ b/compiler/src/main/java/org/apache/flex/compiler/internal/units/ASCompilationUnit.java
@@ -331,12 +331,12 @@ public class ASCompilationUnit extends CompilationUnitBase
{
IRequest<ISyntaxTreeRequestResult, ICompilationUnit> syntaxTreeRequest = this.syntaxTreeRequest.get();
- boolean isBindable = false;
- PackageNode pkg = null;
- ClassNode classNode = null;
- IMetaInfo[] metaInfos = null;
+ //boolean isBindable = false;
+ //PackageNode pkg = null;
+ //ClassNode classNode = null;
+ //IMetaInfo[] metaInfos = null;
final FileNode ast = createFileNode(getRootFileSpecification());
- if (this.getProject() instanceof FlexProject)
+ /*if (this.getProject() instanceof FlexProject)
{
IASNode child = ast.getChild(0);
if (child instanceof PackageNode)
@@ -416,7 +416,7 @@ public class ASCompilationUnit extends CompilationUnitBase
}
}
}
- }
+ }*/
IRequest<IFileScopeRequestResult, ICompilationUnit> fileScopeRequest = this.fileScopeRequest.get();
@@ -428,8 +428,8 @@ public class ASCompilationUnit extends CompilationUnitBase
{
getProject().clearScopeCacheForCompilationUnit(this);
ast.runPostProcess(EnumSet.of(PostProcessStep.POPULATE_SCOPE));
- if (isBindable)
- pkg.getASScope().addImport(BindableHelper.STRING_EVENT_DISPATCHER);
+ //if (isBindable)
+ // pkg.getASScope().addImport(BindableHelper.STRING_EVENT_DISPATCHER);
}
final ImmutableSet<String> includedFiles = ast.getIncludeHandler().getIncludedFiles();
addScopeToProjectScope(new ASFileScope[] { ast.getFileScope() });