You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/31 10:18:46 UTC

[GitHub] [cordova-plugin-media-capture] BardRedStar opened a new pull request #184: iOS: Fixed UI issues with main thread and added alert for permission.

BardRedStar opened a new pull request #184:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/184


   - solved critical error connected with performing the UI operation on the non-UI thread.
   - added the alert dialog for the Microphone permission, if it is not granted.
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   App was crashing, when user didn't give permissions for recording audio.
   
   
   ### Description
   iOS requests the permission on the background thread, and after it all of the operations should be performed on the main thread. So, I got a crash, when attempting to reject the Microphone permission prompt. Basically I change thread after the request for permissions.
   
   
   ### Testing
   I have ran tests, and haven’t got any error.
   
   
   ### Checklist
   
   - [✓] I've run the tests to see all new and existing tests pass
   - [✓] I added automated test coverage as appropriate for this change
   - [✓] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [✓] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [✓] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org