You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/25 14:29:19 UTC
[GitHub] [arrow] pitrou opened a new pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
pitrou opened a new pull request #12255:
URL: https://github.com/apache/arrow/pull/12255
Fix the following compilation error on Ubuntu 18.04:
```
/arrow/cpp/src/arrow/adapters/orc/options.h:73:13: error: In the GNU C Library, "major" is defined
by <sys/sysmacros.h>. For historical compatibility, it is
currently defined by <sys/types.h> as well, but we plan to
remove this soon. To use "major", include <sys/sysmacros.h>
directly. If you did not intend to use a system-defined macro
"major", you should undefine it after including <sys/types.h>. [-Werror]
int32_t major() const { return this->major_version; }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021376927
Benchmark runs are scheduled for baseline = 0fa4b9ca1e7b13ac230f85075d86d783eeea6a74 and contender = 85f67d71381c4dbfbf55377e646b785a643daa0b. 85f67d71381c4dbfbf55377e646b785a643daa0b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ec29b5b27ede4f84b0b57463365ac53f...68a10e5a92d241fabd0750358a6d4e18/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/558272c1011141a184f2376011f85fb2...139a17a167904fa1a6f5551851f051eb/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/28075e1916b54bc1bf42fbad27900d56...06bdde9d71844bbaa5344520f1585978/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021292831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021239845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021376927
Benchmark runs are scheduled for baseline = 0fa4b9ca1e7b13ac230f85075d86d783eeea6a74 and contender = 85f67d71381c4dbfbf55377e646b785a643daa0b. 85f67d71381c4dbfbf55377e646b785a643daa0b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ec29b5b27ede4f84b0b57463365ac53f...68a10e5a92d241fabd0750358a6d4e18/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/558272c1011141a184f2376011f85fb2...139a17a167904fa1a6f5551851f051eb/)
[Finished :arrow_down:0.3% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/28075e1916b54bc1bf42fbad27900d56...06bdde9d71844bbaa5344520f1585978/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021376927
Benchmark runs are scheduled for baseline = 0fa4b9ca1e7b13ac230f85075d86d783eeea6a74 and contender = 85f67d71381c4dbfbf55377e646b785a643daa0b. 85f67d71381c4dbfbf55377e646b785a643daa0b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ec29b5b27ede4f84b0b57463365ac53f...68a10e5a92d241fabd0750358a6d4e18/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/558272c1011141a184f2376011f85fb2...139a17a167904fa1a6f5551851f051eb/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/28075e1916b54bc1bf42fbad27900d56...06bdde9d71844bbaa5344520f1585978/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#discussion_r791769465
##########
File path: python/pyarrow/tests/test_orc.py
##########
@@ -299,219 +299,219 @@ def test_orcfile_readwrite_with_bad_writeoptions():
# batch_size must be a positive integer
with pytest.raises(ValueError):
orc.write_table(
- buffer_output_stream,
table,
+ buffer_output_stream,
Review comment:
This fixes some warnings when running the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021239845
@iajoiner FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021312166
Revision: fc1a462f8183772f69fa5415b6649bc2feba4ab0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1485](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1485)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1485-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-debian-11-cpp-i386)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-fedora-33-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1485-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021376927
Benchmark runs are scheduled for baseline = 0fa4b9ca1e7b13ac230f85075d86d783eeea6a74 and contender = 85f67d71381c4dbfbf55377e646b785a643daa0b. 85f67d71381c4dbfbf55377e646b785a643daa0b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ec29b5b27ede4f84b0b57463365ac53f...68a10e5a92d241fabd0750358a6d4e18/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/558272c1011141a184f2376011f85fb2...139a17a167904fa1a6f5551851f051eb/)
[Finished :arrow_down:0.3% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/28075e1916b54bc1bf42fbad27900d56...06bdde9d71844bbaa5344520f1585978/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12255:
URL: https://github.com/apache/arrow/pull/12255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021292831
https://issues.apache.org/jira/browse/ARROW-15447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#discussion_r791769465
##########
File path: python/pyarrow/tests/test_orc.py
##########
@@ -299,219 +299,219 @@ def test_orcfile_readwrite_with_bad_writeoptions():
# batch_size must be a positive integer
with pytest.raises(ValueError):
orc.write_table(
- buffer_output_stream,
table,
+ buffer_output_stream,
Review comment:
This fixes some warnings when running the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12255:
URL: https://github.com/apache/arrow/pull/12255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021240552
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12255:
URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021376927
Benchmark runs are scheduled for baseline = 0fa4b9ca1e7b13ac230f85075d86d783eeea6a74 and contender = 85f67d71381c4dbfbf55377e646b785a643daa0b. 85f67d71381c4dbfbf55377e646b785a643daa0b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ec29b5b27ede4f84b0b57463365ac53f...68a10e5a92d241fabd0750358a6d4e18/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/558272c1011141a184f2376011f85fb2...139a17a167904fa1a6f5551851f051eb/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/28075e1916b54bc1bf42fbad27900d56...06bdde9d71844bbaa5344520f1585978/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org