You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by MBoustani <gi...@git.apache.org> on 2014/06/07 00:20:05 UTC
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
GitHub user MBoustani opened a pull request:
https://github.com/apache/climate/pull/67
CLIMATE-466 update plotter for bettwe color bar.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MBoustani/climate CLIMATE-466
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit 381d367e9bbf36e04b10521b0e59b9cbd6a41f44
Author: Maziyar Boustani <ma...@yahoo.com>
Date: 2014-06-06T22:18:45Z
CLIMATE-466 update plotter for bettwe color bar.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by MBoustani <gi...@git.apache.org>.
Github user MBoustani closed the pull request at:
https://github.com/apache/climate/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/67#issuecomment-45390084
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by MBoustani <gi...@git.apache.org>.
Github user MBoustani commented on the pull request:
https://github.com/apache/climate/pull/67#issuecomment-45390807
Alex,
I thought we never going to have all negative values.
If we do have, then yes I should change on what you said.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/67#issuecomment-45390080
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/67#issuecomment-45739798
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/67#issuecomment-45427134
:+1: to that Alex. Cheers for checking this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the pull request:
https://github.com/apache/climate/pull/67#issuecomment-45391101
Hi Mazi,
I don't think there is a reason to assume that the values will never be negative. I recommend implementing the change I suggested anyway since it is very simple and gives the same result when the minimum is negative and the maximum is positive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/67#issuecomment-45390155
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on a diff in the pull request:
https://github.com/apache/climate/pull/67#discussion_r13513738
--- Diff: ocw/plotter.py ---
@@ -61,8 +61,19 @@ def _nice_intervals(data, nlevs):
# Find the min and max levels by cutting off the tails of the distribution
# This mitigates the influence of outliers
data = data.ravel()
- mnlvl = mstats.scoreatpercentile(data, 5)
- mxlvl = mstats.scoreatpercentile(data, 95)
+ mn = mstats.scoreatpercentile(data, 5)
+ mx = mstats.scoreatpercentile(data, 95)
+ #if there min less than 0 then
+ #put 0 in center of color bar
+ if mn < 0:
--- End diff --
This line should be changed to
```python
if mn < 0 and mx > 0:
```
because otherwise you will end up centering the contours at 0 when the maximum value is negative. This results in superfluous contour levels.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/67#issuecomment-45739912
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-466 update plotter for bettwe color ...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/67#issuecomment-45739812
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---