You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2011/08/10 15:52:33 UTC
Re: Review Request: Move ee_gadgets_render RPC handler into embedded
experiences feature code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1330/
-----------------------------------------------------------
(Updated 2011-08-10 13:52:33.420351)
Review request for shindig, Stanton Sievers and Dan Dumont.
Changes
-------
Fixed spacing issues and added Shindig dev list to the reviewers.
Summary
-------
Right now for a container to render embedded experiences they must define and rpc handler to handle the ee_gadget_rendered rpc request. All the container does in this handler is get the context information from the EE data model and pass it to a callback. This is pretty much the same for every container so it does not make much sense to have every container implement this handler. Its probably better to just have the handler in the container feature code.
This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1563.
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1563
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1155104
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1155177
Diff: https://reviews.apache.org/r/1330/diff
Testing
-------
Reference implementation works
Thanks,
Ryan
Re: Review Request: Move ee_gadgets_render RPC handler into embedded
experiences feature code
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1330/#review1375
-----------------------------------------------------------
Ship it!
LGTM
- Dan
On 2011-08-10 13:55:56, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1330/
> -----------------------------------------------------------
>
> (Updated 2011-08-10 13:55:56)
>
>
> Review request for shindig, Stanton Sievers and Dan Dumont.
>
>
> Summary
> -------
>
> Right now for a container to render embedded experiences they must define and rpc handler to handle the ee_gadget_rendered rpc request. All the container does in this handler is get the context information from the EE data model and pass it to a callback. This is pretty much the same for every container so it does not make much sense to have every container implement this handler. Its probably better to just have the handler in the container feature code.
>
>
> This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1563.
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1563
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1155104
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1155177
>
> Diff: https://reviews.apache.org/r/1330/diff
>
>
> Testing
> -------
>
> Reference implementation works
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Move ee_gadgets_render RPC handler into embedded
experiences feature code
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1330/
-----------------------------------------------------------
(Updated 2011-08-10 13:55:56.558931)
Review request for shindig, Stanton Sievers and Dan Dumont.
Changes
-------
Removed unused variables.
Summary
-------
Right now for a container to render embedded experiences they must define and rpc handler to handle the ee_gadget_rendered rpc request. All the container does in this handler is get the context information from the EE data model and pass it to a callback. This is pretty much the same for every container so it does not make much sense to have every container implement this handler. Its probably better to just have the handler in the container feature code.
This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1563.
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1563
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1155104
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1155177
Diff: https://reviews.apache.org/r/1330/diff
Testing
-------
Reference implementation works
Thanks,
Ryan