You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openwebbeans.apache.org by st...@apache.org on 2013/02/14 08:11:57 UTC
svn commit: r1446053 - in
/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans:
component/creation/ProducerMethodBeanBuilder.java
portable/ProducerMethodProducer.java util/WebBeansUtil.java
Author: struberg
Date: Thu Feb 14 07:11:56 2013
New Revision: 1446053
URL: http://svn.apache.org/r1446053
Log:
OWB-344 remove unused code and document removal candidates
Modified:
openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/creation/ProducerMethodBeanBuilder.java
openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/portable/ProducerMethodProducer.java
openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java
Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/creation/ProducerMethodBeanBuilder.java
URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/creation/ProducerMethodBeanBuilder.java?rev=1446053&r1=1446052&r2=1446053&view=diff
==============================================================================
--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/creation/ProducerMethodBeanBuilder.java (original)
+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/component/creation/ProducerMethodBeanBuilder.java Thu Feb 14 07:11:56 2013
@@ -36,6 +36,7 @@ import org.apache.webbeans.util.ClassUti
public class ProducerMethodBeanBuilder<T> extends AbstractProducerBeanBuilder<T, AnnotatedMethod<?>, ProducerMethodBean<T>>
{
+ //X TODO arne: this should get evaluated or deleted if not needed anymore
private boolean specialized;
public ProducerMethodBeanBuilder(InjectionTargetBean<T> parent, AnnotatedMethod<?> annotatedMethod, BeanAttributesImpl<T> beanAttributes)
@@ -71,7 +72,8 @@ public class ProducerMethodBeanBuilder<T
bean.setSpecializedBean(true);
}
-
+
+ //X TODO arne: this should get implemented or removed if not needed anymore
protected AnnotatedMethod<?> getSuperAnnotated()
{
AnnotatedMethod<?> thisMethod = annotatedMember;
Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/portable/ProducerMethodProducer.java
URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/portable/ProducerMethodProducer.java?rev=1446053&r1=1446052&r2=1446053&view=diff
==============================================================================
--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/portable/ProducerMethodProducer.java (original)
+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/portable/ProducerMethodProducer.java Thu Feb 14 07:11:56 2013
@@ -57,17 +57,12 @@ public class ProducerMethodProducer<T, P
this.owner = owner;
}
- public void setDisposalMethod(AnnotatedMethod<P> disposalMethod)
- {
- this.disposalMethod = disposalMethod;
- }
-
@Override
public T produce(CreationalContext<T> creationalContext)
{
P parentInstance = null;
CreationalContext<P> parentCreationalContext = null;
- InjectableMethod<T> m = null;
+ InjectableMethod<T> m;
try
{
parentCreationalContext = webBeansContext.getBeanManagerImpl().createCreationalContext(owner);
@@ -98,7 +93,7 @@ public class ProducerMethodProducer<T, P
{
P parentInstance = null;
CreationalContext<P> parentCreationalContext = null;
- InjectableMethod<T> m = null;
+ InjectableMethod<T> m;
try
{
parentCreationalContext = webBeansContext.getBeanManagerImpl().createCreationalContext(owner);
Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java
URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java?rev=1446053&r1=1446052&r2=1446053&view=diff
==============================================================================
--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java (original)
+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java Thu Feb 14 07:11:56 2013
@@ -1569,27 +1569,6 @@ public final class WebBeansUtil
return managedBean;
}
-
- /**
- * Determines if the injection is to be performed into a static field.
- *
- * @param injectionPoint
- * @return <code>true</code> if the injection is into a static field
- */
- public static boolean isStaticInjection(InjectionPoint injectionPoint)
- {
- if (injectionPoint != null)
- {
- Member member = injectionPoint.getMember();
- if (member != null && Modifier.isStatic(member.getModifiers()))
- {
- return true;
- }
- }
-
- return false;
- }
-
public boolean isPassivationCapableDependency(InjectionPoint injectionPoint)
{
//Don't attempt to get an instance of the delegate injection point
@@ -1679,8 +1658,6 @@ public final class WebBeansUtil
public <T> ManagedBean<T> defineManagedBean(AnnotatedType<T> type)
{
- Class<T> clazz = type.getJavaClass();
-
BeanAttributesImpl<T> beanAttributes = BeanAttributesBuilder.forContext(webBeansContext).newBeanAttibutes(type).build();
ManagedBeanBuilder<T, ManagedBean<T>> managedBeanCreator = new ManagedBeanBuilder<T, ManagedBean<T>>(webBeansContext, type, beanAttributes);