You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/28 03:56:12 UTC

[GitHub] [spark] LuciferYang opened a new pull request #35672: [SPARK-38342][CORE] Clean up deprecated api usage of Ivy

LuciferYang opened a new pull request #35672:
URL: https://github.com/apache/spark/pull/35672


   ### What changes were proposed in this pull request?
   This pr use `Ivy.retrieve(ModuleRevisionId, RetrieveOptions)` instead of  deprecated `Ivy.retrieve(ModuleRevisionId, String, RetrieveOptions)` to  clean up deprecation compilation warning.
   
   The refactor way refer to the Implementation of  `RetrieveEngine#retrieve` method as follows:
   
   ```java
       @Deprecated
       public int retrieve(ModuleRevisionId mrid, String destFilePattern, RetrieveOptions options)
               throws IOException {
           RetrieveOptions retrieveOptions = new RetrieveOptions(options);
           retrieveOptions.setDestArtifactPattern(destFilePattern);
   
           RetrieveReport result = retrieve(mrid, retrieveOptions);
           return result.getNbrArtifactsCopied();
       }
   ```
   
   ### Why are the changes needed?
   Clean up deprecated api usage.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #35672: [SPARK-38342][CORE] Clean up deprecated api usage of Ivy

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35672:
URL: https://github.com/apache/spark/pull/35672#issuecomment-1056940429


   thanks all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #35672: [SPARK-38342][CORE] Clean up deprecated api usage of Ivy

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35672:
URL: https://github.com/apache/spark/pull/35672


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] mridulm commented on pull request #35672: [SPARK-38342][CORE] Clean up deprecated api usage of Ivy

Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #35672:
URL: https://github.com/apache/spark/pull/35672#issuecomment-1054964480


   +CC @xkrogen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #35672: [SPARK-38342][CORE] Clean up deprecated api usage of Ivy

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35672:
URL: https://github.com/apache/spark/pull/35672#issuecomment-1056938026


   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org