You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Chad Schoettger (JIRA)" <de...@beehive.apache.org> on 2005/10/10 17:42:48 UTC
[jira] Created: (BEEHIVE-968) Remove workaround for old apt bug from AptControlInterface
Remove workaround for old apt bug from AptControlInterface
----------------------------------------------------------
Key: BEEHIVE-968
URL: http://issues.apache.org/jira/browse/BEEHIVE-968
Project: Beehive
Type: Improvement
Components: Controls
Reporter: Chad Schoettger
Assigned to: Chad Schoettger
Priority: Minor
at line 341 of AptControlInterface:
// HACKHACK: There appear to be mirror API bugs where calling getAnnotation()
// on certain entity types will result in an endless loop. For now, work around
// this by a priori filtering... but this mechanism will drop errors that appear
// on an inapropriate type (see check below)
if (! (innerDecl instanceof AnnotationTypeDeclaration))
continue;
This code should be cleaned up - assuming this is no longer an issue with apt.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (BEEHIVE-968) Remove workaround for old apt bug
from AptControlInterface
Posted by "matt c (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-968?page=comments#action_12376057 ]
matt c commented on BEEHIVE-968:
--------------------------------
Verified fixed using local beehive build synced to SVN 393036 by examining code.
Verified that the comments have been removed.
The current code now looks like this:
for (TypeDeclaration innerDecl : _intfDecl.getNestedTypes())
{
boolean fError = false;
if (innerDecl.getAnnotation(PropertySet.class) != null)
{
if (! (innerDecl instanceof AnnotationTypeDeclaration))
{
This bug may be closed.
> Remove workaround for old apt bug from AptControlInterface
> ----------------------------------------------------------
>
> Key: BEEHIVE-968
> URL: http://issues.apache.org/jira/browse/BEEHIVE-968
> Project: Beehive
> Type: Improvement
> Components: Controls
> Reporter: Chad Schoettger
> Assignee: Eddie O'Neil
> Priority: Minor
> Fix For: 1.0.1
> Attachments: BEEHIVE-968.diff
>
> at line 341 of AptControlInterface:
> // HACKHACK: There appear to be mirror API bugs where calling getAnnotation()
> // on certain entity types will result in an endless loop. For now, work around
> // this by a priori filtering... but this mechanism will drop errors that appear
> // on an inapropriate type (see check below)
> if (! (innerDecl instanceof AnnotationTypeDeclaration))
> continue;
> This code should be cleaned up - assuming this is no longer an issue with apt.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-968) Remove workaround for old apt bug from AptControlInterface
Posted by "Chad Schoettger (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-968?page=all ]
Chad Schoettger reassigned BEEHIVE-968:
---------------------------------------
Assign To: Eddie O'Neil (was: Chad Schoettger)
to Eddie for review/commit
> Remove workaround for old apt bug from AptControlInterface
> ----------------------------------------------------------
>
> Key: BEEHIVE-968
> URL: http://issues.apache.org/jira/browse/BEEHIVE-968
> Project: Beehive
> Type: Improvement
> Components: Controls
> Reporter: Chad Schoettger
> Assignee: Eddie O'Neil
> Priority: Minor
> Attachments: BEEHIVE-968.diff
>
> at line 341 of AptControlInterface:
> // HACKHACK: There appear to be mirror API bugs where calling getAnnotation()
> // on certain entity types will result in an endless loop. For now, work around
> // this by a priori filtering... but this mechanism will drop errors that appear
> // on an inapropriate type (see check below)
> if (! (innerDecl instanceof AnnotationTypeDeclaration))
> continue;
> This code should be cleaned up - assuming this is no longer an issue with apt.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (BEEHIVE-968) Remove workaround for old apt bug from
AptControlInterface
Posted by "Eddie O'Neil (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-968?page=all ]
Eddie O'Neil closed BEEHIVE-968:
--------------------------------
Closing...this was just a bug to remove some comments.
> Remove workaround for old apt bug from AptControlInterface
> ----------------------------------------------------------
>
> Key: BEEHIVE-968
> URL: http://issues.apache.org/jira/browse/BEEHIVE-968
> Project: Beehive
> Type: Improvement
> Components: Controls
> Reporter: Chad Schoettger
> Assignee: Eddie O'Neil
> Priority: Minor
> Fix For: 1.0.1
> Attachments: BEEHIVE-968.diff
>
> at line 341 of AptControlInterface:
> // HACKHACK: There appear to be mirror API bugs where calling getAnnotation()
> // on certain entity types will result in an endless loop. For now, work around
> // this by a priori filtering... but this mechanism will drop errors that appear
> // on an inapropriate type (see check below)
> if (! (innerDecl instanceof AnnotationTypeDeclaration))
> continue;
> This code should be cleaned up - assuming this is no longer an issue with apt.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-968) Remove workaround for old apt bug from AptControlInterface
Posted by "Chad Schoettger (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-968?page=all ]
Chad Schoettger updated BEEHIVE-968:
------------------------------------
Attachment: BEEHIVE-968.diff
Cannot find a case which will cause apt to hang, removing 'HACK,HACK' block of code for previous work around.
> Remove workaround for old apt bug from AptControlInterface
> ----------------------------------------------------------
>
> Key: BEEHIVE-968
> URL: http://issues.apache.org/jira/browse/BEEHIVE-968
> Project: Beehive
> Type: Improvement
> Components: Controls
> Reporter: Chad Schoettger
> Assignee: Chad Schoettger
> Priority: Minor
> Attachments: BEEHIVE-968.diff
>
> at line 341 of AptControlInterface:
> // HACKHACK: There appear to be mirror API bugs where calling getAnnotation()
> // on certain entity types will result in an endless loop. For now, work around
> // this by a priori filtering... but this mechanism will drop errors that appear
> // on an inapropriate type (see check below)
> if (! (innerDecl instanceof AnnotationTypeDeclaration))
> continue;
> This code should be cleaned up - assuming this is no longer an issue with apt.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-968) Remove workaround for old apt bug from AptControlInterface
Posted by "Eddie O'Neil (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-968?page=all ]
Eddie O'Neil resolved BEEHIVE-968:
----------------------------------
Fix Version: 1.1
Resolution: Fixed
Fixed in SVN 332370.
> Remove workaround for old apt bug from AptControlInterface
> ----------------------------------------------------------
>
> Key: BEEHIVE-968
> URL: http://issues.apache.org/jira/browse/BEEHIVE-968
> Project: Beehive
> Type: Improvement
> Components: Controls
> Reporter: Chad Schoettger
> Assignee: Eddie O'Neil
> Priority: Minor
> Fix For: 1.1
> Attachments: BEEHIVE-968.diff
>
> at line 341 of AptControlInterface:
> // HACKHACK: There appear to be mirror API bugs where calling getAnnotation()
> // on certain entity types will result in an endless loop. For now, work around
> // this by a priori filtering... but this mechanism will drop errors that appear
> // on an inapropriate type (see check below)
> if (! (innerDecl instanceof AnnotationTypeDeclaration))
> continue;
> This code should be cleaned up - assuming this is no longer an issue with apt.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira