You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/01/25 00:51:34 UTC
Review Request: reduce memory usage of SLA query (invoked by CLI command) to
avoid OOM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/
-----------------------------------------------------------
Review request for oozie.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1187
This addresses bug OOZIE-1187.
https://issues.apache.org/jira/browse/OOZIE-1187
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1437603
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1437603
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603
Diff: https://reviews.apache.org/r/9104/diff/
Testing
-------
locally tested. ran coordinator jobs with SLA tag inserted
Thanks,
Ryota Egashira
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/#review15722
-----------------------------------------------------------
Ship it!
looks fine. Disclaimer here as we discussed before, that later we may decide to revamp the SLA architecture completely.
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java
<https://reviews.apache.org/r/9104/#comment33873>
better to remove these commented lines altogether
- Mona Chitnis
On Jan. 25, 2013, 8:19 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9104/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 8:19 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> This addresses bug OOZIE-1187.
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1437603
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1437603
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1437603
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1437603
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1437603
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1437603
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603
>
> Diff: https://reviews.apache.org/r/9104/diff/
>
>
> Testing
> -------
>
> locally tested. ran coordinator jobs with SLA tag inserted
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Feb. 2, 2013, 10:44 p.m., Rohini Palaniswamy wrote:
> > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki, lines 750-752
> > <https://reviews.apache.org/r/9104/diff/7/?file=254946#file254946line750>
> >
> > We can avoid a new example. We can add offset option to the previous example and a note that offset is same as sequenceid to be concise.
>
> Ryota Egashira wrote:
> we should keep both examples separate to minimize confusion. one customer didn't know -offset set to be sequenceid - 1, having both examples help clarify that as well.
>
That was because there is no mention that offset and sequence-id are same. Just mentioning that should be sufficient. The previous example itself can be modified to reflect the same.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/#review16040
-----------------------------------------------------------
On Feb. 2, 2013, 7:35 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9104/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2013, 7:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> This addresses bug OOZIE-1187.
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1440866
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1440866
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1440866
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1440866
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1440866
> trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1440866
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1440866
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1440866
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1440866
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1440866
>
> Diff: https://reviews.apache.org/r/9104/diff/
>
>
> Testing
> -------
>
> locally tested. ran coordinator jobs with SLA tag inserted
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On Feb. 2, 2013, 10:44 p.m., Rohini Palaniswamy wrote:
> > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki, lines 750-752
> > <https://reviews.apache.org/r/9104/diff/7/?file=254946#file254946line750>
> >
> > We can avoid a new example. We can add offset option to the previous example and a note that offset is same as sequenceid to be concise.
we should keep both examples separate to minimize confusion. one customer didn't know -offset set to be sequenceid - 1, having both examples help clarify that as well.
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/#review16040
-----------------------------------------------------------
On Feb. 2, 2013, 7:35 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9104/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2013, 7:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> This addresses bug OOZIE-1187.
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1440866
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1440866
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1440866
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1440866
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1440866
> trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1440866
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1440866
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1440866
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1440866
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1440866
>
> Diff: https://reviews.apache.org/r/9104/diff/
>
>
> Testing
> -------
>
> locally tested. ran coordinator jobs with SLA tag inserted
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/#review16040
-----------------------------------------------------------
Looks good. Just a minor doc change recommendation.
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/9104/#comment34346>
We can avoid a new example. We can add offset option to the previous example and a note that offset is same as sequenceid to be concise.
- Rohini Palaniswamy
On Feb. 2, 2013, 7:35 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9104/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2013, 7:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> This addresses bug OOZIE-1187.
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1440866
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1440866
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1440866
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1440866
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1440866
> trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1440866
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1440866
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1440866
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1440866
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1440866
>
> Diff: https://reviews.apache.org/r/9104/diff/
>
>
> Testing
> -------
>
> locally tested. ran coordinator jobs with SLA tag inserted
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/
-----------------------------------------------------------
(Updated Feb. 9, 2013, 12:41 a.m.)
Review request for oozie.
Changes
-------
discussed with Rohini, and changed documentation.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1187
This addresses bug OOZIE-1187.
https://issues.apache.org/jira/browse/OOZIE-1187
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444151
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444151
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1444151
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1444151
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1444151
trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1444151
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1444151
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1444151
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444151
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444151
Diff: https://reviews.apache.org/r/9104/diff/
Testing
-------
locally tested. ran coordinator jobs with SLA tag inserted
Thanks,
Ryota Egashira
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/
-----------------------------------------------------------
(Updated Feb. 2, 2013, 7:35 a.m.)
Review request for oozie.
Changes
-------
accomodated Rohini's comments
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1187
This addresses bug OOZIE-1187.
https://issues.apache.org/jira/browse/OOZIE-1187
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1440866
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1440866
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1440866
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1440866
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1440866
trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1440866
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1440866
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1440866
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1440866
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1440866
Diff: https://reviews.apache.org/r/9104/diff/
Testing
-------
locally tested. ran coordinator jobs with SLA tag inserted
Thanks,
Ryota Egashira
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/#review16033
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java
<https://reviews.apache.org/r/9104/#comment34332>
Revert to older query as we discussed offline
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java
<https://reviews.apache.org/r/9104/#comment34330>
Please revert to older behaviour as discussed offline
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java
<https://reviews.apache.org/r/9104/#comment34331>
Please retain this as discussed offline
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java
<https://reviews.apache.org/r/9104/#comment34333>
Revert to full SLAEventBean
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java
<https://reviews.apache.org/r/9104/#comment34334>
To be removed
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java
<https://reviews.apache.org/r/9104/#comment34335>
Is your eclipse formatter settings right?
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java
<https://reviews.apache.org/r/9104/#comment34336>
Is your eclipse formatter settings right?
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java
<https://reviews.apache.org/r/9104/#comment34337>
Why these hardcoded values?
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/9104/#comment34338>
max is limited by a oozie server setting which defaults to 1000
- Rohini Palaniswamy
On Jan. 31, 2013, 12:23 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9104/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2013, 12:23 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> This addresses bug OOZIE-1187.
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1440731
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1440731
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1440731
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1440731
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1440731
> trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1440731
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1440731
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1440731
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1440731
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1440731
>
> Diff: https://reviews.apache.org/r/9104/diff/
>
>
> Testing
> -------
>
> locally tested. ran coordinator jobs with SLA tag inserted
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/
-----------------------------------------------------------
(Updated Jan. 31, 2013, 12:23 a.m.)
Review request for oozie.
Changes
-------
modified docs to include example how to get SLA events with particular sequence ID using -offset and -len 1
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1187
This addresses bug OOZIE-1187.
https://issues.apache.org/jira/browse/OOZIE-1187
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1440731
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1440731
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1440731
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1440731
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1440731
trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1440731
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1440731
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1440731
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1440731
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1440731
Diff: https://reviews.apache.org/r/9104/diff/
Testing
-------
locally tested. ran coordinator jobs with SLA tag inserted
Thanks,
Ryota Egashira
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/
-----------------------------------------------------------
(Updated Jan. 28, 2013, 8:57 p.m.)
Review request for oozie.
Changes
-------
modified pre-commit build failure
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1187
This addresses bug OOZIE-1187.
https://issues.apache.org/jira/browse/OOZIE-1187
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1439527
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1439527
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1439527
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1439527
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1439527
trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1439527
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1439527
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1439527
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1439527
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1439527
Diff: https://reviews.apache.org/r/9104/diff/
Testing
-------
locally tested. ran coordinator jobs with SLA tag inserted
Thanks,
Ryota Egashira
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/
-----------------------------------------------------------
(Updated Jan. 26, 2013, 12:07 a.m.)
Review request for oozie.
Changes
-------
deleted parts Mona pointed out.
Thanks you all for comments!
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1187
This addresses bug OOZIE-1187.
https://issues.apache.org/jira/browse/OOZIE-1187
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1437603
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1437603
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1437603
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1437603
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1437603
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1437603
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603
Diff: https://reviews.apache.org/r/9104/diff/
Testing
-------
locally tested. ran coordinator jobs with SLA tag inserted
Thanks,
Ryota Egashira
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/
-----------------------------------------------------------
(Updated Jan. 25, 2013, 8:19 p.m.)
Review request for oozie.
Changes
-------
accomodated Virag's comments
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1187
This addresses bug OOZIE-1187.
https://issues.apache.org/jira/browse/OOZIE-1187
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1437603
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1437603
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1437603
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1437603
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1437603
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1437603
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603
Diff: https://reviews.apache.org/r/9104/diff/
Testing
-------
locally tested. ran coordinator jobs with SLA tag inserted
Thanks,
Ryota Egashira
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On Jan. 25, 2013, 2:11 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java, line 46
> > <https://reviews.apache.org/r/9104/diff/2/?file=251878#file251878line46>
> >
> > It seems that all columns are retrieved which is not different from select *.
> > Can you check whether some of the columns (mainly blob's) are internal to Oozie and not useful for the user?
good point.
current implementation is that, when SLA even status in Created, giving values in all columns, and when status is in STARTED, SUCCEEDED, KILLED, FAILED, giving only subset. thus, in query, fetching all columns.
I created OOZIE-1189 which can be used to fetch all columns on particular SLA event, so in this JIRA, should be enough to give only subset (as long as giving sequence ID and SLA ID, which later used to get details).
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/#review15670
-----------------------------------------------------------
On Jan. 25, 2013, 12:18 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9104/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 12:18 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> This addresses bug OOZIE-1187.
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1437603
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1437603
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603
>
> Diff: https://reviews.apache.org/r/9104/diff/
>
>
> Testing
> -------
>
> locally tested. ran coordinator jobs with SLA tag inserted
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/#review15670
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java
<https://reviews.apache.org/r/9104/#comment33803>
It seems that all columns are retrieved which is not different from select *.
Can you check whether some of the columns (mainly blob's) are internal to Oozie and not useful for the user?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java
<https://reviews.apache.org/r/9104/#comment33804>
It will be good to add a test case for this JPA executor
- Virag Kothari
On Jan. 25, 2013, 12:18 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9104/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 12:18 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> This addresses bug OOZIE-1187.
> https://issues.apache.org/jira/browse/OOZIE-1187
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1437603
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1437603
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603
>
> Diff: https://reviews.apache.org/r/9104/diff/
>
>
> Testing
> -------
>
> locally tested. ran coordinator jobs with SLA tag inserted
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: reduce memory usage of SLA query (invoked by CLI
command) to avoid OOM
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/
-----------------------------------------------------------
(Updated Jan. 25, 2013, 12:18 a.m.)
Review request for oozie.
Changes
-------
added minor doc change
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1187
This addresses bug OOZIE-1187.
https://issues.apache.org/jira/browse/OOZIE-1187
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1437603
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1437603
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603
Diff: https://reviews.apache.org/r/9104/diff/
Testing
-------
locally tested. ran coordinator jobs with SLA tag inserted
Thanks,
Ryota Egashira