You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2023/05/09 07:08:14 UTC

[GitHub] [yunikorn-site] FrankYang0529 opened a new pull request, #293: [YUNIKORN-1726] remove duplicate pages

FrankYang0529 opened a new pull request, #293:
URL: https://github.com/apache/yunikorn-site/pull/293

   ### What is this PR for?
   Remove duplicate pages:
   * K8s Scheduler Plugin
   * Gang scheduling design
   * Kubernetes Shim Design
   
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [X] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-1726
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-site] 0yukali0 commented on a diff in pull request #293: [YUNIKORN-1726] remove duplicate pages

Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on code in PR #293:
URL: https://github.com/apache/yunikorn-site/pull/293#discussion_r1188271123


##########
versioned_sidebars/version-1.2.0-sidebars.json:
##########
@@ -51,9 +51,6 @@
         "label": "Designs",
         "items": [
           "design/architecture",
-          "design/k8shim",

Review Comment:
   Hi @FrankYang0529 , I noticed the k8shim doc has been moved to the archived design.
   So you are right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-site] 0yukali0 merged pull request #293: [YUNIKORN-1726] remove duplicate pages

Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 merged PR #293:
URL: https://github.com/apache/yunikorn-site/pull/293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-site] FrankYang0529 commented on a diff in pull request #293: [YUNIKORN-1726] remove duplicate pages

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #293:
URL: https://github.com/apache/yunikorn-site/pull/293#discussion_r1188297588


##########
versioned_sidebars/version-1.2.0-sidebars.json:
##########
@@ -51,9 +51,6 @@
         "label": "Designs",
         "items": [
           "design/architecture",
-          "design/k8shim",

Review Comment:
   It's duplicated with the document in archived_design.
   
   https://github.com/apache/yunikorn-site/blob/2ba654958ec73d6b036822d32b657442dd70b66f/versioned_sidebars/version-1.2.0-sidebars.json#L75 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-site] 0yukali0 commented on a diff in pull request #293: [YUNIKORN-1726] remove duplicate pages

Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on code in PR #293:
URL: https://github.com/apache/yunikorn-site/pull/293#discussion_r1188260200


##########
versioned_sidebars/version-1.2.0-sidebars.json:
##########
@@ -51,9 +51,6 @@
         "label": "Designs",
         "items": [
           "design/architecture",
-          "design/k8shim",

Review Comment:
   Hi @FrankYang0529.
   design/k8shim isn't duplicate in the version-1.2.0-sidebars.
   Why did you remove it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org