You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by "Shinichiro Abe (JIRA)" <ji...@apache.org> on 2011/09/09 07:47:08 UTC
[jira] [Created] (CONNECTORS-251) jcifs.jar download
jcifs.jar download
------------------
Key: CONNECTORS-251
URL: https://issues.apache.org/jira/browse/CONNECTORS-251
Project: ManifoldCF
Issue Type: Improvement
Components: JCIFS connector
Affects Versions: ManifoldCF next
Reporter: Shinichiro Abe
Priority: Minor
Fix For: ManifoldCF next
Attachments: CONNECTORS-251.patch
jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-251) jcifs.jar download
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101048#comment-13101048 ]
Karl Wright commented on CONNECTORS-251:
----------------------------------------
We cannot redistribute jcifs.jar, but the code can certainly download it. So you can go ahead and commit this patch too.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF next
> Reporter: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF next
>
> Attachments: CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-251) jcifs.jar download
Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shinichiro Abe updated CONNECTORS-251:
--------------------------------------
Attachment: CONNECTORS-251.patch
Do we have a licece problem?
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF next
> Reporter: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF next
>
> Attachments: CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-251) jcifs.jar download
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102003#comment-13102003 ]
Karl Wright commented on CONNECTORS-251:
----------------------------------------
It occurred to me also that the JDBC connector could benefit from this. It should download the jtds MSSQL/Sybase JDBC driver, and maybe (if we can figure out how) the Oracle JDBC driver.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF 0.4
> Reporter: Shinichiro Abe
> Assignee: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF 0.4
>
> Attachments: CONNECTORS-251-1.patch, CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-251) jcifs.jar download
Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shinichiro Abe updated CONNECTORS-251:
--------------------------------------
Attachment: CONNECTORS-251-2.patch
Thank you for reviewing. I moved the processes to each connector's build.xml and I inclueded JDBC.
But Oracle jdbc driver couldn't be downloaded automatically. 1. Users have to sign up to oracle site. 2. Even though user signs up, user can't get normal jar file of correct size by using Ant. The site redirected into another sites several times until stating to download, and the size of file downloaded was 4KB instead of 2MB. I didn't know the reason. Thus I included jtds only at this time.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF 0.4
> Reporter: Shinichiro Abe
> Assignee: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF 0.4
>
> Attachments: CONNECTORS-251-1.patch, CONNECTORS-251-2.patch, CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-251) jcifs.jar download
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101049#comment-13101049 ]
Karl Wright commented on CONNECTORS-251:
----------------------------------------
The only caution I have is that, if the person is running off of the net, the download might fail. The conditional logic looks like it would catch that situation though. Just so long as the build does not fail in that case.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF next
> Reporter: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF next
>
> Attachments: CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-251) jcifs.jar download
Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103285#comment-13103285 ]
Shinichiro Abe commented on CONNECTORS-251:
-------------------------------------------
Thank you. r1170008.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF 0.4
> Reporter: Shinichiro Abe
> Assignee: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF 0.4
>
> Attachments: CONNECTORS-251-1.patch, CONNECTORS-251-2.patch, CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CONNECTORS-251) jcifs.jar download
Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shinichiro Abe resolved CONNECTORS-251.
---------------------------------------
Resolution: Fixed
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF 0.4
> Reporter: Shinichiro Abe
> Assignee: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF 0.4
>
> Attachments: CONNECTORS-251-1.patch, CONNECTORS-251-2.patch, CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-251) jcifs.jar download
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101050#comment-13101050 ]
Karl Wright commented on CONNECTORS-251:
----------------------------------------
Final comment: Since we build the images for distribution using ant, we need some way of PREVENTING the download in that case.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF next
> Reporter: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF next
>
> Attachments: CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-251) jcifs.jar download
Posted by "Shinichiro Abe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shinichiro Abe updated CONNECTORS-251:
--------------------------------------
Attachment: CONNECTORS-251-1.patch
When selecting "download-dependencies", is it better for user to select download target again(display echo)?
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF 0.4
> Reporter: Shinichiro Abe
> Assignee: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF 0.4
>
> Attachments: CONNECTORS-251-1.patch, CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-251) jcifs.jar download
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103187#comment-13103187 ]
Karl Wright commented on CONNECTORS-251:
----------------------------------------
This looks very good. I think it is now ready to commit.
Sorry about the Oracle jar problem - I think they make it impossible because they want all your contact info first.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF 0.4
> Reporter: Shinichiro Abe
> Assignee: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF 0.4
>
> Attachments: CONNECTORS-251-1.patch, CONNECTORS-251-2.patch, CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-251) jcifs.jar download
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101115#comment-13101115 ]
Karl Wright commented on CONNECTORS-251:
----------------------------------------
Your second patch looks reasonable and the help message is OK.
I was thinking, though, that each connector's build.xml have a "download-dependencies" target, and the root build.xml file invoke all connector "download-dependencies" targets. That way the logic of what happens is distributed to the connector level.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF 0.4
> Reporter: Shinichiro Abe
> Assignee: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF 0.4
>
> Attachments: CONNECTORS-251-1.patch, CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-251) jcifs.jar download
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wright updated CONNECTORS-251:
-----------------------------------
Affects Version/s: (was: ManifoldCF next)
ManifoldCF 0.4
Fix Version/s: (was: ManifoldCF next)
ManifoldCF 0.4
Assignee: Shinichiro Abe
Best to hold off on the commit until we've worked out how to prevent unwanted download. The best way to do it might be to have a common well-known target for each connector, "execute-download". The root-level build can then choose whether or not to make that a dependency or not, based on the main target chosen.
I'm happy to make the infrastructure changes to the ant build necessary to support this model change. Please let me know.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF 0.4
> Reporter: Shinichiro Abe
> Assignee: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF 0.4
>
> Attachments: CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-251) jcifs.jar download
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101058#comment-13101058 ]
Karl Wright commented on CONNECTORS-251:
----------------------------------------
Thinking further on this, making this completely automatic won't work because there's no good way in ant to make one dependency of a target fire before another dependency of the same target, without linking the two dependencies together. So instead I'd propose we introduce a new root-level target as well, "download-dependencies", which does the job of picking up the non-redistributable dependencies for all connectors. In practice this will just be the jcifs.jar at this time. But the build structure should support each connector making the determination of what to download.
> jcifs.jar download
> ------------------
>
> Key: CONNECTORS-251
> URL: https://issues.apache.org/jira/browse/CONNECTORS-251
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Affects Versions: ManifoldCF 0.4
> Reporter: Shinichiro Abe
> Assignee: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF 0.4
>
> Attachments: CONNECTORS-251.patch
>
>
> jcifs.jar should be downloaded automatically at jcifs/build.xml as a approach similar to pom.xml.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira