You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "egalpin (via GitHub)" <gi...@apache.org> on 2023/06/09 22:38:49 UTC
[GitHub] [beam] egalpin commented on a diff in pull request #26424: Handle response exception from Elasticsearch client
egalpin commented on code in PR #26424:
URL: https://github.com/apache/beam/pull/26424#discussion_r1224857843
##########
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##########
@@ -373,6 +376,8 @@ abstract static class Builder {
abstract Builder setTrustSelfSignedCerts(boolean trustSelfSignedCerts);
+ abstract Builder setInvalidBulkEndpoint(boolean invalidBulkEndpoint);
Review Comment:
I don't particularly like the idea of having this builder method only for the sake of testing. I feel it will be very confusing to users to see this as an option when building configurations. Could you look for an alternative approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org