You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by jm...@apache.org on 2018/11/09 05:29:28 UTC
[08/14] guacamole-client git commit: GUACAMOLE-220: Clarify usage of
SimpleUser and SimpleUserGroup.
GUACAMOLE-220: Clarify usage of SimpleUser and SimpleUserGroup.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-client/commit/90a6d8e3
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-client/tree/90a6d8e3
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-client/diff/90a6d8e3
Branch: refs/heads/master
Commit: 90a6d8e371181e8e4e626a2cee5aed9fd0b0b678
Parents: d533de1
Author: Michael Jumper <mj...@apache.org>
Authored: Sat Nov 3 14:14:04 2018 -0700
Committer: Michael Jumper <mj...@apache.org>
Committed: Sat Nov 3 14:14:04 2018 -0700
----------------------------------------------------------------------
.../java/org/apache/guacamole/net/auth/simple/SimpleUser.java | 6 ++++--
.../org/apache/guacamole/net/auth/simple/SimpleUserGroup.java | 4 +++-
2 files changed, 7 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/90a6d8e3/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUser.java
----------------------------------------------------------------------
diff --git a/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUser.java b/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUser.java
index 9530392..d85cc97 100644
--- a/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUser.java
+++ b/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUser.java
@@ -36,7 +36,9 @@ import org.apache.guacamole.net.auth.permission.ObjectPermissionSet;
import org.apache.guacamole.net.auth.permission.SystemPermissionSet;
/**
- * An extremely basic User implementation.
+ * A read-only User implementation which has no permissions. Implementations
+ * that need to define permissions should extend this class and override the
+ * associated getters.
*/
public class SimpleUser extends AbstractUser {
@@ -62,7 +64,7 @@ public class SimpleUser extends AbstractUser {
}
/**
- * Creates a new SimpleUser having the given username and no permissions.
+ * Creates a new SimpleUser having the given username.
*
* @param username
* The username to assign to this SimpleUser.
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/90a6d8e3/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUserGroup.java
----------------------------------------------------------------------
diff --git a/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUserGroup.java b/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUserGroup.java
index 83b7ce9..77b3741 100644
--- a/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUserGroup.java
+++ b/guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleUserGroup.java
@@ -29,7 +29,9 @@ import org.apache.guacamole.net.auth.permission.ObjectPermissionSet;
import org.apache.guacamole.net.auth.permission.SystemPermissionSet;
/**
- * A read-only UserGroup implementation which has no members.
+ * A read-only UserGroup implementation which has no members and no
+ * permissions. Implementations that need to define members or permissions
+ * should extend this class and override the associated getters.
*/
public class SimpleUserGroup extends AbstractIdentifiable implements UserGroup {