You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/20 10:33:12 UTC

[GitHub] [tvm] manupa-arm commented on issue #11785: [CI Problem] PyLint version update causing new `ci_lint` image to report many linting issues

manupa-arm commented on issue #11785:
URL: https://github.com/apache/tvm/issues/11785#issuecomment-1160278212

   I think you mean #11734  ? :)
   
   I think landing the docker change early leaves the codebase in a in-consistent state, especially where the the follow-up change is not trivial. As a policy, we should think of a way to reduce the gap (ideally there should not be a gap but that will only happen with #11768)
   
   Is there an urgency of landing #11734 ? (especially, if the next one is not ready at the same time - we need to ensure both are ready before landing a one). Eitherway, we should only be landing the former when the latter is ready, especially in pylint upgrades where the fixes are non-trivial. However, this policy is tricky to be implemented.
   
   If not we can just wait until #11768 that removes this two PR based flow of updating docker.
   
   My suggestion is to : 
   * revert #11734 for now
   * wait until work is done on #11768
   * then re-do #11734 with actual changes that is required to do the update.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org