You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/05/25 18:24:13 UTC

[GitHub] [hadoop] ayushtkn commented on pull request #4320: HADOOP-18236. Remove duplicate locks in NetworkTopology

ayushtkn commented on PR #4320:
URL: https://github.com/apache/hadoop/pull/4320#issuecomment-1137686111

   Logically from the present code flow this lock is redundant and there is enough discussion on the original jira, this was kept because the method calling was protected and a comment there confirms that it is indeed deliberate
   https://issues.apache.org/jira/browse/HADOOP-16028?focusedCommentId=16731433&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16731433
   
   I don't think we can change this access modifier to private for compat reasons and the reason for which it was done then still holds true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org