[GitHub] [helix] kaisun2000 commented on a change in pull request #974: Enforce result check for data accessors batch get calls to prevent partial batch read.

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #974:
URL: https://github.com/apache/helix/pull/974#discussion_r425335493



##########
File path: helix-core/src/main/java/org/apache/helix/common/caches/TaskDataCache.java
##########
@@ -194,9 +194,9 @@ private void refreshContextsAndPreviousAssignments(HelixDataAccessor accessor) {
       }
     }
 
-    List<ZNRecord> contexts = accessor.getBaseDataAccessor().get(contextPaths, null, 0);
+    List<ZNRecord> contexts = accessor.getBaseDataAccessor().get(contextPaths, null, 0, true);

Review comment:
       Does it mean if passing true here, it would throw exception? Then how do we handle this exception? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org