You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/11 09:07:34 UTC

Review Request 43473: Speed up ContenderDetectorShutdownNetwork by advance Clock.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43473/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-4649
    https://issues.apache.org/jira/browse/MESOS-4649


Repository: mesos


Description
-------

Speed up ContenderDetectorShutdownNetwork by advance Clock.


Diffs
-----

  src/tests/master_contender_detector_tests.cpp 6375586c31b1fd406529bf299dad6e321b945de8 

Diff: https://reviews.apache.org/r/43473/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 43473: Speed up ContenderDetectorShutdownNetwork by advance Clock.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43473/
-----------------------------------------------------------

(Updated April 10, 2016, 10:18 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
-------

Update according to @alexr's comments.


Bugs: MESOS-4650
    https://issues.apache.org/jira/browse/MESOS-4650


Repository: mesos


Description
-------

Speed up ContenderDetectorShutdownNetwork by advance Clock.


Diffs (updated)
-----

  src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a 

Diff: https://reviews.apache.org/r/43473/diff/


Testing (updated)
-------

Test repeatly in CentOS 7.1

```
 sudo ./bin/mesos-tests.sh --gtest_filter="ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork " --verbose --gtest_repeat=200 --gtest_break_on_failure
```

Before

```
[       OK ] ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork (3390 ms)
```

After

```
[       OK ] ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork (546 ms)
```


Thanks,

haosdent huang


Re: Review Request 43473: Speed up ContenderDetectorShutdownNetwork by advance Clock.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43473/
-----------------------------------------------------------

(Updated Feb. 11, 2016, 8:13 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4650
    https://issues.apache.org/jira/browse/MESOS-4650


Repository: mesos


Description
-------

Speed up ContenderDetectorShutdownNetwork by advance Clock.


Diffs
-----

  src/tests/master_contender_detector_tests.cpp 6375586c31b1fd406529bf299dad6e321b945de8 

Diff: https://reviews.apache.org/r/43473/diff/


Testing (updated)
-------

Before

```
[       OK ] ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork (3390 ms)
```

After

```
[       OK ] ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork (546 ms)
```


Thanks,

haosdent huang