You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/04/24 17:52:38 UTC

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2613: [GOBBLIN-748]Craftsmanship code cleaning in Gobblin Service Code

autumnust commented on a change in pull request #2613: [GOBBLIN-748]Craftsmanship code cleaning in Gobblin Service Code
URL: https://github.com/apache/incubator-gobblin/pull/2613#discussion_r278246896
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
 ##########
 @@ -357,10 +357,9 @@ private void initialize(Dag<JobExecutionPlan> dag)
     }
 
     /**
-     * Poll the statuses of running jobs.
-     * @return List of {@link JobStatus}es.
+     * Proceed the execution of each dag node based on job status.
      */
-    private void pollJobStatuses()
+    private void proceedDagExecutionOnDagNodeStatus()
 
 Review comment:
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services