You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "SchopenhauerZhang (via GitHub)" <gi...@apache.org> on 2023/10/11 07:06:34 UTC
[PR] add config of maxFilterMessageSize [rocketmq]
SchopenhauerZhang opened a new pull request, #7447:
URL: https://github.com/apache/rocketmq/pull/7447
https://github.com/apache/rocketmq/issues/7446
add config of maxFilterMessageSize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add config of maxFilterMessageSize [rocketmq]
Posted by "SchopenhauerZhang (via GitHub)" <gi...@apache.org>.
SchopenhauerZhang commented on PR #7447:
URL: https://github.com/apache/rocketmq/pull/7447#issuecomment-1756986300
@RongtongJin help ,CR,please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add config of maxFilterMessageSize [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7447:
URL: https://github.com/apache/rocketmq/pull/7447#issuecomment-1913874102
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `14 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`4acb43e`)](https://app.codecov.io/gh/apache/rocketmq/commit/4acb43ecee03e429d036e3ff4c28bd402d1b30c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 42.68% compared to head [(`552b049`)](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.31%.
> Report is 90 commits behind head on develop.
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/rocketmq/common/message/Message.java](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlLmphdmE=) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/rocketmq/store/config/MessageStoreConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2NvbmZpZy9NZXNzYWdlU3RvcmVDb25maWcuamF2YQ==) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #7447 +/- ##
=============================================
+ Coverage 42.68% 43.31% +0.63%
- Complexity 9477 9888 +411
=============================================
Files 1150 1173 +23
Lines 82814 85051 +2237
Branches 10768 11014 +246
=============================================
+ Hits 35346 36841 +1495
- Misses 43045 43647 +602
- Partials 4423 4563 +140
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7447?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add config of maxFilterMessageSize [rocketmq]
Posted by "humkum (via GitHub)" <gi...@apache.org>.
humkum commented on PR #7447:
URL: https://github.com/apache/rocketmq/pull/7447#issuecomment-1757496773
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org