You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Lokesh Jain (JIRA)" <ji...@apache.org> on 2018/05/04 17:28:00 UTC

[jira] [Comment Edited] (RATIS-236) Use TimeoutScheduler in RaftClientImpl

    [ https://issues.apache.org/jira/browse/RATIS-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464165#comment-16464165 ] 

Lokesh Jain edited comment on RATIS-236 at 5/4/18 5:27 PM:
-----------------------------------------------------------

[~szetszwo] Thanks for working on this! The patch looks good to me. Please find my comment below.

TimeoutScheduler#getNumThreads might lead to NullPointerException on a race condition.


was (Author: ljain):
[~szetszwo] Thanks for working on this! The patch looks good to me. 

TimeoutScheduler#getNumThreads might lead to NullPointerException on a race condition.

> Use TimeoutScheduler in RaftClientImpl
> --------------------------------------
>
>                 Key: RATIS-236
>                 URL: https://issues.apache.org/jira/browse/RATIS-236
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>         Attachments: r236_20180503.patch
>
>
> TimeoutScheduler is thread safe and have auto-shutdown when there are no tasks.  Let's also use it in RaftClientImpl for submitting retry requests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)