You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/01 11:11:36 UTC

[GitHub] [ozone] GlenGeng edited a comment on pull request #1852: HDDS-4761. Implement increment count optimization in DeletedBlockLog V2

GlenGeng edited a comment on pull request #1852:
URL: https://github.com/apache/ozone/pull/1852#issuecomment-770772130


   @amaliujia  Thanks for back port this fix to HDDS-2823.
   
   I consider we have to move `transactionRetryCountMap` from `DeletedBlockLogStateManagerImpl#increaseRetryCountOfTransactionInDB` to `DeletedBlockLogImplV2#incrementCount`, and clear it when SCM becomes leader.
   
   The reason is, content of `DeletedBlockLogImplV2` should be kept consistent and deterministic across SCM instance, which is not necessary and can not be maintained during SCM failover. 
   
   The design decision is only encapsulate `deletedTable` into `DeletedBlockLogImplV2`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org