You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/01/26 20:46:45 UTC

[GitHub] [nuttx] pkarashchenko commented on pull request #8242: nuttx: apply misc fixes in code noticed during code review

pkarashchenko commented on PR #8242:
URL: https://github.com/apache/nuttx/pull/8242#issuecomment-1405629550

   > I don't think that posix API should return nuttx defines such as ERROR or OK.Of course no harm done here, since ERROR happens to be -1. It is however just making reading code difficult.
   
   I just updated to use the same style as in most of the other places (like `sem_post` or `sem_wait` and many others).
   Do you recommend replacing all `ERROR` with `-1` in all POSIX API return points?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org