[GitHub] [hive] deniskuzZ commented on a diff in pull request #4307: count(*) should be using Iceberg basic stats if present

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #4307:
URL: https://github.com/apache/hive/pull/4307#discussion_r1190954414


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java:
##########
@@ -299,7 +299,8 @@ public Object process(Node nd, Stack<Node> stack, NodeProcessorCtx procCtx,
           Logger.info("Table " + tbl.getTableName() + " is external. Skip StatsOptimizer.");
           return null;
         }
-        if (MetaStoreUtils.isNonNativeTable(tbl.getTTable())) {
+        if (MetaStoreUtils.isNonNativeTable(tbl.getTTable())

Review Comment:
   This is a more generic check. If non-native table can provide stats - we should use it (tbl.getStorageHandler().canProvideBasicStatistics()). 
   At this moment only 'iceberg' has support for that, default is false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org