[GitHub] [maven] gnodet commented on pull request #473: [MNG-6915] Adapt the logging width to the terminal width, including s…

[GitBox <gi...@apache.org>]

gnodet commented on pull request #473:
URL: https://github.com/apache/maven/pull/473#issuecomment-844793089


   @MartinKanters it seems to work.  I've forced pushed the change.
   
   Fwiw, there is a minor problem with the terminal width which can be improved later: ideally, we'd make the difference between the `System.out` and `System.err` streams.  Currently, `MessageUtils.getTerminalWidth()` relies on `AnsiConsole.getTerminalWidth()` which first tries the get the width of the terminal using `System.out` and then try with `System.err`.  The downside is that if the output is redirected using `mvn > out.txt` or even simply `mvn -l out.txt`, then the computed terminal width is not relevant.  It's no big deal though.  This also makes we wonder if the `MavenCli` should use `System.err` to print non standard output (i.e. version, help, etc...) instead of `System.out`...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org