You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by da...@apache.org on 2020/02/06 09:33:50 UTC

[incubator-nuttx] branch master updated: fix stm32_spibus_initialize: ensure leave_critical_section is called

This is an automated email from the ASF dual-hosted git repository.

davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new 729af00  fix stm32_spibus_initialize: ensure leave_critical_section is called
     new 4c0bc30  Merge pull request #212 from bkueng/stm32_spibus_initialize_fix
729af00 is described below

commit 729af004c0754a75ebb49c1000530c5f1b7e6efe
Author: Beat Küng <be...@gmx.net>
AuthorDate: Wed Feb 5 08:35:32 2020 +0100

    fix stm32_spibus_initialize: ensure leave_critical_section is called
    
    in case the requested SPI bus is invalid or not configured.
---
 arch/arm/src/stm32/stm32_spi.c       | 1 -
 arch/arm/src/stm32f0l0g0/stm32_spi.c | 1 -
 arch/arm/src/stm32f7/stm32_spi.c     | 1 -
 arch/arm/src/stm32h7/stm32_spi.c     | 1 -
 4 files changed, 4 deletions(-)

diff --git a/arch/arm/src/stm32/stm32_spi.c b/arch/arm/src/stm32/stm32_spi.c
index 8a636f4..c2cb1d8 100644
--- a/arch/arm/src/stm32/stm32_spi.c
+++ b/arch/arm/src/stm32/stm32_spi.c
@@ -2120,7 +2120,6 @@ FAR struct spi_dev_s *stm32_spibus_initialize(int bus)
 #endif
     {
       spierr("ERROR: Unsupported SPI bus: %d\n", bus);
-      return NULL;
     }
 
   leave_critical_section(flags);
diff --git a/arch/arm/src/stm32f0l0g0/stm32_spi.c b/arch/arm/src/stm32f0l0g0/stm32_spi.c
index fb782f1..2e728e6 100644
--- a/arch/arm/src/stm32f0l0g0/stm32_spi.c
+++ b/arch/arm/src/stm32f0l0g0/stm32_spi.c
@@ -1778,7 +1778,6 @@ FAR struct spi_dev_s *stm32_spibus_initialize(int bus)
 #endif
     {
       spierr("ERROR: Unsupported SPI bus: %d\n", bus);
-      return NULL;
     }
 
   leave_critical_section(flags);
diff --git a/arch/arm/src/stm32f7/stm32_spi.c b/arch/arm/src/stm32f7/stm32_spi.c
index 8fbbaa2..bc8bb08 100644
--- a/arch/arm/src/stm32f7/stm32_spi.c
+++ b/arch/arm/src/stm32f7/stm32_spi.c
@@ -2178,7 +2178,6 @@ FAR struct spi_dev_s *stm32_spibus_initialize(int bus)
 #endif
     {
       spierr("ERROR: Unsupported SPI bus: %d\n", bus);
-      return NULL;
     }
 
   leave_critical_section(flags);
diff --git a/arch/arm/src/stm32h7/stm32_spi.c b/arch/arm/src/stm32h7/stm32_spi.c
index c1b9026..b84ed1c 100644
--- a/arch/arm/src/stm32h7/stm32_spi.c
+++ b/arch/arm/src/stm32h7/stm32_spi.c
@@ -2279,7 +2279,6 @@ FAR struct spi_dev_s *stm32_spibus_initialize(int bus)
 #endif
     {
       spierr("ERROR: Unsupported SPI bus: %d\n", bus);
-      return NULL;
     }
 
   leave_critical_section(flags);