You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by bitchelov <gi...@git.apache.org> on 2016/12/12 11:54:49 UTC

[GitHub] zeppelin pull request #1746: Collection.isEmpty() should be used to test for...

GitHub user bitchelov opened a pull request:

    https://github.com/apache/zeppelin/pull/1746

    Collection.isEmpty() should be used to test for emptiness

    ### What is this PR for?
    A few sentences describing the overall goals of the pull request's commits.
    First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
    
    
    ### What type of PR is it?
    [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
    
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?
    
    Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bitchelov/zeppelin severalChangesCollection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1746
    
----
commit e2dae2fc97057c90e51ffaa199c695925266db2c
Author: sergey_sokur <so...@gmail.com>
Date:   2016-12-12T11:50:29Z

    Collection.isEmpty() should be used to test for emptiness

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1746: Collection.isEmpty() should be used to test for emptin...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1746
  
    LGTM and merge if there're no further discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1746: Collection.isEmpty() should be used to test for emptin...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1746
  
    @bitchelov Thanks for the contribution.
    Do you mind update description of the PR?
    PR description will be part of commit message when merged. So we expect some meaningful description for future reference.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1746: Collection.isEmpty() should be used to test for...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1746


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---