[GitHub] [spark] zhengruifeng commented on a diff in pull request #41311: [SPARK-43792][SQL][PYTHON][CONNECT] Add optional pattern for Catalog.listCatalogs

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #41311:
URL: https://github.com/apache/spark/pull/41311#discussion_r1209973491


##########
python/pyspark/sql/catalog.py:
##########
@@ -119,11 +119,16 @@ def setCurrentCatalog(self, catalogName: str) -> None:
         """
         return self._jcatalog.setCurrentCatalog(catalogName)
 
-    def listCatalogs(self) -> List[CatalogMetadata]:
+    def listCatalogs(self, pattern: Optional[str] = None) -> List[CatalogMetadata]:
         """Returns a list of catalogs in this session.
 
         .. versionadded:: 3.4.0
 
+        Parameters
+        ----------
+        pattern : str
+            The pattern that the catalog name needs to match.

Review Comment:
   please add a `versionadded` for this new parameter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org