[GitHub] spark pull request #22234: [SPARK-25241][SQL] Configurable empty values when...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22234#discussion_r214572617
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala ---
    @@ -79,7 +79,8 @@ private[csv] object CSVInferSchema {
        * point checking if it is an Int, as the final type must be Double or higher.
        */
       def inferField(typeSoFar: DataType, field: String, options: CSVOptions): DataType = {
    -    if (field == null || field.isEmpty || field == options.nullValue) {
    +    if (field == null || field.isEmpty || field == options.nullValue ||
    +      field == options.emptyValueInRead) {
    --- End diff --
    
    I wouldn't do this for now. It needs another review iteration. Let's revert this back.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org