[GitHub] d3zd3z commented on a change in pull request #108: RFC: Add support for encrypted private keys

[GitBox <gi...@apache.org>]

d3zd3z commented on a change in pull request #108: RFC: Add support for encrypted private keys
URL: https://github.com/apache/mynewt-newt/pull/108#discussion_r158391936
 
 

 ##########
 File path: newt/image/image.go
 ##########
 @@ -536,7 +579,7 @@ func (image *Image) generateV1(loader *Image) error {
 	}
 
 	imgFile, err := os.OpenFile(image.TargetImg,
-		os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0777)
+		os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0666)
 
 Review comment:
   Normally, writes are done with 0666, which is then masked by the user's umask. A user who sets their umask to 0 should be expecting files to be world writable (or at least someone scripting it this way). In other words, it is the umask's job to filter the permissions, not individual apps.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services