You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/17 20:53:35 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #25048: corrected the airflow variable hyper-link

uranusjr commented on code in PR #25048:
URL: https://github.com/apache/airflow/pull/25048#discussion_r922894343


##########
docs/apache-airflow/howto/dynamic-dag-generation.rst:
##########
@@ -29,7 +29,7 @@ If you want to use variables to configure your code, you should always use
 `environment variables <https://wiki.archlinux.org/title/environment_variables>`_ in your
 top-level code rather than :doc:`Airflow Variables </concepts/variables>`. Using Airflow Variables
 at top-level code creates a connection to metadata DB of Airflow to fetch the value, which can slow
-down parsing and place extra load on the DB. See the `Airflow Variables <_best_practices/airflow_variables>`_
+down parsing and place extra load on the DB. See the :doc:`Airflow Variables <_best_practices/airflow_variables>`

Review Comment:
   ```suggestion
   down parsing and place extra load on the DB. See the :doc:`Airflow Variables <best_practices/airflow_variables>`
   ```
   
   Leading underscore is a special restructuredText syntax (reference) and not a part of the actual object name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org