You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/06/27 17:44:40 UTC
[GitHub] [jena] afs opened a new pull request, #1406: JENA-2333: Sorting simple strings and language string.
afs opened a new pull request, #1406:
URL: https://github.com/apache/jena/pull/1406
This address the report of JENA-2333
It changes the ordering on terms of differing categories (value spaces). e.g. string and integers so that the string (simple and language) are before other datatypes. Previously (up to Jena 4.5.0) the comparison of differing categories was by lexical form first.
But two languages, compared by NodeValue, the value-sensitive comparison, was by language tag. This leads to an unstable sort (it is not a total ordering because the condition `A<B` and `B<C` implies `A<C` is not always true. JENA-2333 respots a case where this unstable sort leads to ant exception from `Arrays.sort` from the JDK.
This PR is an alternative to #1404.
----
- [ ] Tests are included.
- [ ] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1406: JENA-2333: Sorting simple strings and language string.
Posted by GitBox <gi...@apache.org>.
afs merged PR #1406:
URL: https://github.com/apache/jena/pull/1406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1406: JENA-2333: Sorting simple strings and language string.
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1406:
URL: https://github.com/apache/jena/pull/1406#issuecomment-1167671546
cc @litvinovg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1406: JENA-2333: Sorting simple strings and language string.
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1406:
URL: https://github.com/apache/jena/pull/1406#issuecomment-1172957839
[Email to dev@ about this change](https://lists.apache.org/thread/c65sbt9fvc005538xjplp34nqdzgb18t).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1406: JENA-2333: Sorting simple strings and language string.
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1406:
URL: https://github.com/apache/jena/pull/1406#issuecomment-1167673566
This is "draft" at the moment. Currently, some tests and scripted tests fail and unalike datatype comparison is by old-style lexical form - switching to datatype-before-lexical makes sense design-wise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1406: JENA-2333: Sorting simple strings and language string.
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1406:
URL: https://github.com/apache/jena/pull/1406#issuecomment-1173931346
The tests have now updated for new sorting order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org